Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for rename and go.mod support #461

Merged
merged 1 commit into from
May 10, 2019
Merged

Updates for rename and go.mod support #461

merged 1 commit into from
May 10, 2019

Conversation

derekcollison
Copy link
Member

Signed-off-by: Derek Collison [email protected]

@kozlovic
Copy link
Member

@derekcollison This is not triggering Travis-ci because of the name change you think? chicken and egg problem?

@wallyqs
Copy link
Member

wallyqs commented May 10, 2019

Also need to update import in this test:

"github.com/nats-io/go-nats/encoders/builtin"

@derekcollison
Copy link
Member Author

Travis is running, not sure what you mean.

@derekcollison
Copy link
Member Author

Thanks Wally, will update.

@derekcollison
Copy link
Member Author

Updated Travis and Coveralls

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 92.506% when pulling 070f952 on rename into d15e194 on master.

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants